fix(fslib): handle .zip in the middle of file name again
#3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context that function was added in #2796 to speed up installs / replace this regex .*?(?<!\/)\.zip(?=\/|$)We need to verify that this fix doesn't regress the performance to the point where we could just use the regex |
|
@merceyz Before: After: |
merceyz
requested changes
Jun 22, 2021
|
@merceyz Which test case is in your mind? The change should have handled multiple |
merceyz
reviewed
Jun 23, 2021
merceyz
changed the title
.zip in the middle of file name again
ratson
force-pushed
the
fix-zip-path-extraction
branch
from
b730180 to
485f09f
Compare
ratson
force-pushed
the
fix-zip-path-extraction
branch
from
485f09f to
64cd587
Compare
ratson
force-pushed
the
fix-zip-path-extraction
branch
from
64cd587 to
ee5f023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Path with
.zipin the middle of the file name is not extracted correctly.Closes #2975
How did you fix it?
Added 2 edge cases to the test.
...
Checklist